Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprecision refactoring #98

Merged
merged 18 commits into from
Dec 10, 2024
Merged

Multiprecision refactoring #98

merged 18 commits into from
Dec 10, 2024

Conversation

ioxid
Copy link
Contributor

@ioxid ioxid commented Oct 18, 2024

No description provided.

@ioxid ioxid requested a review from martun October 18, 2024 16:07
@ioxid ioxid force-pushed the multiprecision-refactoring branch from 09b7a67 to 30fc662 Compare October 24, 2024 10:28
@ioxid ioxid self-assigned this Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Clang Test Results

  159 files  +  9    159 suites  +9   18m 13s ⏱️ - 7m 47s
3 176 tests +146  3 170 ✅ +146  6 💤 ±0  0 ❌ ±0 
3 264 runs  +172  3 258 ✅ +172  6 💤 ±0  0 ❌ ±0 

Results for commit 53a6f4a. ± Comparison against base commit 0ced39c.

This pull request removes 38 and adds 184 tests. Note that renamed tests count towards both. 
integral_fixed_test_suite ‑ integral_fixed_cpp_int_backend_23
integral_fixed_test_suite ‑ integral_fixed_cpp_int_backend_64
integral_fixed_test_suite ‑ integral_fixed_cpp_uint512
integral_fixed_test_suite ‑ integral_fixed_uint1024
integral_fixed_test_suite_bits ‑ integral_fixed_cpp_int_backend_23_bits
integral_fixed_test_suite_bits ‑ integral_fixed_cpp_int_backend_64_bits
integral_fixed_test_suite_bits ‑ integral_fixed_cpp_uint512_bits
integral_fixed_test_suite_bits ‑ integral_fixed_uint1024_bits
integral_non_fixed_test_suite ‑ integral_non_fixed_checked_int1024_be
integral_non_fixed_test_suite ‑ integral_non_fixed_checked_int1024_le
…

addition ‑ multilimb
addition ‑ multilimb_rev
addition ‑ simple
addition ‑ wraps
addition ‑ wraps_rev
convert ‑ from_int64_t
convert ‑ from_uint64_t
convert ‑ to_uint64_t
cpp_int_conversion ‑ from_cpp_int
cpp_int_conversion ‑ to_cpp_int
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Gcc Test Results

  159 files  + 9    159 suites  +9   19m 0s ⏱️ - 2m 20s
3 172 tests +49  3 166 ✅ +49  6 💤 ±0  0 ❌ ±0 
3 260 runs  +75  3 254 ✅ +75  6 💤 ±0  0 ❌ ±0 

Results for commit 53a6f4a. ± Comparison against base commit 0ced39c.

This pull request removes 32 and adds 81 tests. Note that renamed tests count towards both. 
integral_fixed_test_suite ‑ integral_fixed_cpp_int_backend_23
integral_fixed_test_suite ‑ integral_fixed_cpp_int_backend_64
integral_fixed_test_suite ‑ integral_fixed_cpp_uint512
integral_fixed_test_suite ‑ integral_fixed_uint1024
integral_fixed_test_suite_bits ‑ integral_fixed_cpp_int_backend_23_bits
integral_fixed_test_suite_bits ‑ integral_fixed_cpp_int_backend_64_bits
integral_fixed_test_suite_bits ‑ integral_fixed_cpp_uint512_bits
integral_fixed_test_suite_bits ‑ integral_fixed_uint1024_bits
integral_non_fixed_test_suite ‑ integral_non_fixed_checked_int1024_be
integral_non_fixed_test_suite ‑ integral_non_fixed_checked_int1024_le
…

addition ‑ multilimb
addition ‑ multilimb_rev
addition ‑ simple
addition ‑ wraps
addition ‑ wraps_rev
convert ‑ from_int64_t
convert ‑ from_uint64_t
convert ‑ to_uint64_t
cpp_int_conversion ‑ from_cpp_int
cpp_int_conversion ‑ to_cpp_int
…

♻️ This comment has been updated with latest results.

@ioxid ioxid force-pushed the multiprecision-refactoring branch 3 times, most recently from 656991a to f0ffd23 Compare November 4, 2024 13:32
@ioxid ioxid force-pushed the multiprecision-refactoring branch 12 times, most recently from 95daa6b to 4a7967a Compare November 14, 2024 10:05
@ioxid ioxid force-pushed the multiprecision-refactoring branch 4 times, most recently from 4b96e98 to 48dc8bc Compare November 29, 2024 11:16
@ioxid ioxid marked this pull request as ready for review November 29, 2024 13:29
@ioxid ioxid force-pushed the multiprecision-refactoring branch 4 times, most recently from 947b0f7 to c09c6bf Compare December 3, 2024 14:08
martun
martun reviewed Dec 10, 2024
View reviewed changes
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/big_int.hpp Show resolved Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/big_int.hpp Show resolved Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/big_int.hpp Show resolved Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/big_uint_impl.hpp Show resolved Hide resolved
crypto3/libs/hash/include/nil/crypto3/hash/block_to_field_elements_wrapper.hpp Outdated Show resolved Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/modular/ops/pow.hpp Show resolved Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/ops/import_export.hpp Show resolved Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/ops/import_export.hpp Show resolved Hide resolved
crypto3/libs/multiprecision/include/nil/crypto3/multiprecision/ops/powm.hpp Show resolved Hide resolved
crypto3/libs/transpiler/test/circuit1_lpc/gate_argument.sol Outdated Show resolved Hide resolved
@ioxid ioxid force-pushed the multiprecision-refactoring branch 2 times, most recently from 21dd283 to cda5c6c Compare December 10, 2024 13:45
@ioxid ioxid force-pushed the multiprecision-refactoring branch from 07a004c to aeba2b8 Compare December 10, 2024 16:43
@ioxid ioxid force-pushed the multiprecision-refactoring branch from aeba2b8 to 53a6f4a Compare December 10, 2024 16:47
@ioxid ioxid enabled auto-merge December 10, 2024 17:00
@martun martun self-requested a review December 10, 2024 17:55
@ioxid ioxid added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit eec3173 Dec 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun martun approved these changes

Assignees

@ioxid ioxid

Labels
multiprecision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioxid @martun